feat: support vendor defined mechanisms #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Direktor799 <[email protected]>
Signed-off-by: Direktor799 <[email protected]>
Signed-off-by: Direktor799 <[email protected]>
Direktor799
force-pushed
the
feat/vendor-defined-mechanism
branch
from
85b6f7e
to
12e21fa
Compare
hug-dev
reviewed
Nov 11, 2024
Signed-off-by: Direktor799 <[email protected]>
ionut-arm
reviewed
Nov 11, 2024
| // SPDX-License-Identifier: Apache-2.0 | ||
| //! Mechanism types are defined with the objects and mechanism descriptions that use them. | ||
| //! Vendor defined values for this type may also be specified. | ||
| //! See: <https://docs.oasis-open.org/pkcs11/pkcs11-base/v3.0/os/pkcs11-base-v3.0-os.html#_Toc29976545> |
There was a problem hiding this comment.
Are vendor mechanisms only supported in v3 of PKCS #11?
There was a problem hiding this comment.
It's also supported in v2.4. I put v3.0 link here since we are using v3.0 headers now.
ionut-arm
approved these changes
Nov 12, 2024
My casual skim reveals they don't have any: https://github.com/opendnssec/SoftHSMv2/blob/913e7bfd463194fadcdd28f578087cc9c15643ee/src/lib/SoftHSM.cpp#L723 Too bad, it'd be cool to have tests for this 😞 Edit: also, I couldn't help myself to unsee this. 😉 |
This was referenced Nov 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for vendor defined mechanisms.
In order to avoid issues mentioned in #105, the parameters are pre-serialized in
VendorDefinedMechanism::new, so we don't need to introduce generic toMechanismor pay extra cost for dynamic dispatching.It's also guaranteed that the new mechanism value is greater or equal to
CKM_VENDOR_DEFINED.It seems to be working fine with AWS CloudHSM's custom
CKM_SP800_108_COUNTER_KDF.